Skip to content

[QM] Improve behavior of Move Inventory action#8584

Open
6CRIPT wants to merge 5 commits into
mainfrom
bugs/610810-Improve-behavior-of-Move-Inventory-action
Open

[QM] Improve behavior of Move Inventory action#8584
6CRIPT wants to merge 5 commits into
mainfrom
bugs/610810-Improve-behavior-of-Move-Inventory-action

Conversation

@6CRIPT

@6CRIPT 6CRIPT commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Fixes AB#610810

@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Jun 11, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jun 11, 2026
@6CRIPT 6CRIPT marked this pull request as ready for review June 12, 2026 07:10
@6CRIPT 6CRIPT requested a review from a team as a code owner June 12, 2026 07:10
@6CRIPT 6CRIPT enabled auto-merge (squash) June 12, 2026 07:10
@6CRIPT 6CRIPT force-pushed the bugs/610810-Improve-behavior-of-Move-Inventory-action branch from a36dda5 to 47bc0de Compare June 12, 2026 07:53
@6CRIPT 6CRIPT self-assigned this Jun 12, 2026
@6CRIPT 6CRIPT closed this Jun 15, 2026
auto-merge was automatically disabled June 15, 2026 11:27

Pull request was closed

@6CRIPT 6CRIPT reopened this Jun 15, 2026
@6CRIPT 6CRIPT enabled auto-merge (squash) June 15, 2026 11:29
@github-actions

This comment was marked as low quality.

@github-actions

Copy link
Copy Markdown
Contributor

$\textbf{🟡\ Medium\ Severity\ —\ Security} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Destination bin lookup shows all bin types including receive bins

The new OnLookup trigger for DestinationBinCode shows all bins at the destination location via BinList without filtering out restricted bin types (e.g., Receive or Ship bins). A user could inadvertently select a receive bin as a destination, creating inconsistent warehouse state. The ErrorIfFromBinIsReceiveBin guard only protects the source side.

Recommendation:

  • Filter the bin list to exclude bin types where Receive = true or Ship = true, matching the restrictions already enforced on the source side.
DestinationBin.SetRange("Location Code", DestinationLocationCode);
// Exclude receive and ship bins:
DestinationBin.SetRange("Bin Type Code", <PickBinTypes>);
BinList.SetTableView(DestinationBin);

Line mapping was unavailable, so this was posted as an issue comment.

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.


🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

@6CRIPT 6CRIPT closed this Jun 22, 2026
auto-merge was automatically disabled June 22, 2026 06:18

Pull request was closed

@6CRIPT 6CRIPT reopened this Jun 22, 2026
@6CRIPT 6CRIPT enabled auto-merge (squash) June 23, 2026 12:32
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.


🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants