Skip to content

[releases/28.x] [Shopify] Tolerate legacy bulk-operation request data missing unitCost key #8636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
onbuyuka wants to merge 1 commit into
base: releases/28.x
Choose a base branch
from
Open

[releases/28.x] [Shopify] Tolerate legacy bulk-operation request data missing unitCost key #8636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...Apps/W1/Shopify/App/src/Bulk Operations/Codeunits/ShpfyBulkUpdateProductPrice.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ codeunit 30281 "Shpfy Bulk UpdateProductPrice" implements "Shpfy IBulk Operation
ShopifyVariant.Price := JVariant.GetDecimal('price');
ShopifyVariant."Compare at Price" := JVariant.GetDecimal('compareAtPrice');
ShopifyVariant."Updated At" := JVariant.GetDateTime('updatedAt');
ShopifyVariant."Unit Cost" := JVariant.GetDecimal('unitCost');
if JVariant.Contains('unitCost') then
ShopifyVariant."Unit Cost" := JVariant.GetDecimal('unitCost');
ShopifyVariant.Modify();
end;
end;
Expand Down
3 changes: 2 additions & 1 deletion src/Apps/W1/Shopify/App/src/Products/Codeunits/ShpfyProductExport.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -877,7 +877,8 @@ codeunit 30178 "Shpfy Product Export"
ShopifyVariant.Price := JVariant.GetDecimal('price');
ShopifyVariant."Compare at Price" := JVariant.GetDecimal('compareAtPrice');
ShopifyVariant."Updated At" := JVariant.GetDateTime('updatedAt');
ShopifyVariant."Unit Cost" := JVariant.GetDecimal('unitCost');
if JVariant.Contains('unitCost') then
ShopifyVariant."Unit Cost" := JVariant.GetDecimal('unitCost');
ShopifyVariant.Modify();
end;
exit;
Expand Down