[Shopify] Fix AL0132: expose ImportPayout as internal to allow test access#8690
Open
Copilot wants to merge 5 commits into
Open
[Shopify] Fix AL0132: expose ImportPayout as internal to allow test access#8690Copilot wants to merge 5 commits into
Copilot wants to merge 5 commits into
Conversation
…8) (#8548) Codeunit 139593 `"Shpfy Inventory Subscriber"` was reintroduced on the release branch by the API 2026-01 uptake backport (PR #8366) but clashes with the codeunit 139593 in the BCApps Shopify Connector Test 28.0.0.0 baseline, which is checked by BuildCop and the BC platform during NAV gate validation (`VerifyApplicationChanges` failed in job 3581772, NAV PR 248762). ## Fix Renumber the codeunit from 139593 to **134248** and extend the existing `134241-134247` `idRange` in `src/Apps/W1/Shopify/Test/app.json` to `134248`. 134248 is confirmed free across: - NAV source (`C:\depot\NAV2\App\Apps`, `Layers`, `Internal`, `Test`, `Extension`) - BCApps source on `main`, `releases/27.x`, and `releases/27.5` - All 137 `.app` baselines in NAV2 (Shopify Test 25.8 through 29.0 and every other app) All other references to the codeunit use the name `"Shpfy Inventory Subscriber"` rather than the ID, so no callers need to change. Companion fix for releases/27.x: #8547. Fixes [AB#638060](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/638060) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…e-27.0' into copilot/fix-github-actions-job-again
…hpfy Payments API The test UnitTestImportPayoutWithExternalTraceId calls PaymentsAPI.ImportPayout() but ImportPayout was declared as a local procedure, making it inaccessible from the test codeunit. Changing it to internal allows access via the internalsVisibleTo declaration in app.json. Also includes all PR #8683 changes (Shopify API 2026-01 uptake backport to releases/27.0): External Trace Id on Payout table, inventory API rework, unverified return lines, article reference metafield support, and related test updates.
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job Build Apps (W1) (Default)
[Shopify] Fix AL0132: expose ImportPayout as internal to allow test access
Jun 19, 2026
djukicmilica
approved these changes
Jun 21, 2026
Contributor
|
dcenic
approved these changes
Jun 23, 2026
dcenic
approved these changes
Jun 23, 2026
AndersLarsenMicrosoft
approved these changes
Jun 23, 2026
mazhelez
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #8683 (API 2026-01 uptake backport) added a test
UnitTestImportPayoutWithExternalTraceIdthat callsPaymentsAPI.ImportPayout()directly, butImportPayoutwas declaredlocal, making it inaccessible from the test codeunit even thoughShopify Connector Testis listed ininternalsVisibleTo.Fix
ShpfyPaymentsAPI.Codeunit.al: Changelocal procedure ImportPayout→internal procedure ImportPayout, making it callable from the test app via the existinginternalsVisibleTodeclaration.Included changes (API 2026-01 uptake)
This branch also incorporates all changes from PR #8683 that were pending on
releases/27.0:ShpfyPayout.Table.al: NewExternal Trace Idfield (field 16)ShpfyPaymentsAPI.Codeunit.al: MapexternalTraceIdfrom GraphQL response into the new fieldShpfyPaymentsTest.Codeunit.al: New testUnitTestImportPayoutWithExternalTraceIdvalidating the field importGetCurrentBulkOperationremoval, pagination fixes, codeunit ID clash fix (139593 → 134248)Fixes AB#639695