[Bug Fix] #638531: Disable Open TO from PO actions on non-subcontracting lines

[ventselartur]

Bug Reference

ADO Work item #638531 - [Subcontracting] Open TO from PO action only works from main item line

Summary

The "Open TO from PO" actions on the subcontracting Purchase Order lines (Transfer Order / Return Transfer Order) are now disabled when the current line is not a subcontracting line, instead of appearing enabled but silently doing nothing.

Root Cause

The Transfer Order and Return Transfer Order actions in pageextension 99001524 "Subc. PO Subform" call SubcPurchFactboxMgmt.ShowTransferOrdersAndReturnOrder(Rec, ...), which requires the current purchase line's Prod. Order No. and exit(0)s when it is empty. The enclosing group(Production) was gated only at the document level (Visible = HasSubcontractingContext), never per line. So on a component/non-subcontracting line the actions stayed enabled but did nothing - a usability/discoverability defect.

Changes Made

• src/Apps/W1/Subcontracting/App/src/Purchase/SubcPOSubform.PageExt.al: Added an OnAfterGetCurrRecord trigger that computes CurrentLineIsSubcontractingLine from Subcontracting Management.IsSubcontractingPurchaseLine(Rec), and set Enabled = CurrentLineIsSubcontractingLine on action("Transfer Order") and action("Return Transfer Order").
• src/Apps/W1/Subcontracting/Test/Tests/SubcSubcontractingTest.Codeunit.al: Added regression test TransferOrderActionDisabledOnNonSubcontractingPurchaseLine.

Implementation Process

• Fix iterations: 1
• Compilation: All projects compile successfully (full al_build, scope=all)
• Tests: All tests passing

Test Evidence

Pre-Fix Test Results (Baseline)

Run without the fix (deterministic across 3 runs):

FAIL TransferOrderActionDisabledOnNonSubcontractingPurchaseLine
     Assert.IsFalse failed. Transfer Order action must be disabled for a
     non-subcontracting purchase line (no Prod. Order No.).

Post-Fix Test Results (Final)

PASS TransferOrderActionDisabledOnNonSubcontractingPurchaseLine
Test run completed: 3 passed, 0 failed, 0 skipped.

Test Coverage

• New regression test for work item #638531
• Action enabled on a subcontracting line (Prod. Order No. set)
• Action disabled on a non-subcontracting line (no Prod. Order No.) on the same order

Review Notes

The fix relies on the existing internal Subcontracting Management.IsSubcontractingPurchaseLine, which returns true only when Prod. Order No. and Prod. Order Line No. are set.

Generated by the bc-fix-bug skill

[github-actions]

Could not find a linked ADO work item. Please link one by using the pattern 'AB#' followed by the relevant work item number. You may use the 'Fixes' keyword to automatically resolve the work item when the pull request is merged. E.g. 'Fixes AB#1234'