Skip to content

Subscription Billing Infinite loop in CalculateBillingPeriod when HarmonizeNextBillingTo caps at stale "Next Billing To" dateFix and AutomartionAdded Fix #8813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sanjmaurya wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Draft

Subscription Billing Infinite loop in CalculateBillingPeriod when HarmonizeNextBillingTo caps at stale "Next Billing To" dateFix and AutomartionAdded Fix #8813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/Apps/W1/Subscription Billing/App/Billing/Codeunits/BillingProposal.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,6 +483,7 @@ codeunit 8062 "Billing Proposal"
local procedure CalculateBillingPeriod(ServiceCommitment: Record "Subscription Line"; BillingDate: Date; BillToDate: Date; var BillingPeriodStart: Date; var BillingPeriodEnd: Date)
var
UsageDataBilling: Record "Usage Data Billing";
PreviousBillingPeriodEnd: Date;
begin
BillingPeriodEnd := 0D;
BillingPeriodStart := ServiceCommitment."Next Billing Date";
Expand All @@ -505,10 +506,14 @@ codeunit 8062 "Billing Proposal"
end;

BillingPeriodEnd := CalculateNextBillingToDateForServiceCommitment(ServiceCommitment, BillingPeriodStart);
PreviousBillingPeriodEnd := 0D;
while (BillingPeriodEnd < BillingDate) and
((BillingPeriodEnd < ServiceCommitment."Subscription Line End Date") or (ServiceCommitment."Subscription Line End Date" = 0D))
do
((BillingPeriodEnd < ServiceCommitment."Subscription Line End Date") or (ServiceCommitment."Subscription Line End Date" = 0D)) and
(BillingPeriodEnd > PreviousBillingPeriodEnd)
do begin
PreviousBillingPeriodEnd := BillingPeriodEnd;
BillingPeriodEnd := CalculateNextBillingToDateForServiceCommitment(ServiceCommitment, BillingPeriodEnd + 1);
end;
end;

procedure CalculateNextBillingToDateForServiceCommitment(ServiceCommitment: Record "Subscription Line"; BillingFromDate: Date) NextBillingToDate: Date
Expand Down
Loading