Skip to content

Re-enable BCPT Setup Card tests: fix NoOfSqlCallsAreLogged SQL assertion (Bug 618568) #8823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gggdttt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Re-enable BCPT Setup Card tests: fix NoOfSqlCallsAreLogged SQL assertion (Bug 618568) #8823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/Tools/Performance Toolkit/Test/src/BCPTSetupCardTest.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ codeunit 144741 "BCPT Setup Card Test"
BCPTSetupCardTest: Codeunit "BCPT Setup Card Test";
BCPTStartTests: Codeunit "BCPT Start Tests";
BCPTSetupCard: TestPage "BCPT Setup Card";
ActualNoOfIterations: Integer;
UnexpectedNoOfSqlStmtsLbl: Label 'Unexpected value in %1. Expected %2, Actual %3', Locked = true;
begin
Initialize();
Expand All @@ -145,8 +146,13 @@ codeunit 144741 "BCPT Setup Card Test"
BCPTSetupCard.OpenView();
BCPTSetupCard.GoToRecord(BCPTHeader);
BCPTSetupCard.BCPTLines.Status.AssertEquals(BCPTLine.Status::Completed);
Assert.IsTrue(BCPTSetupCard.BCPTLines.NoOfIterations.AsInteger() >= NoOfIterationsToRun, StrSubstNo(UnexpectedNoOfSqlStmtsLbl, BCPTLogEntry.FieldCaption("No. of SQL Statements"), NoOfIterationsToRun, BCPTSetupCard.BCPTLines.NoOfIterations.AsInteger()));
BCPTSetupCard.BCPTLines.NoOfSQLStmts.AssertEquals(NoOfIterationsToRun);
ActualNoOfIterations := BCPTSetupCard.BCPTLines.NoOfIterations.AsInteger();
Assert.IsTrue(ActualNoOfIterations >= NoOfIterationsToRun, StrSubstNo(UnexpectedNoOfSqlStmtsLbl, BCPTSetupCard.BCPTLines.NoOfIterations.Caption, NoOfIterationsToRun, ActualNoOfIterations));
// The codeunit issues exactly 1 SQL statement per iteration, but the very first database access in the session also
// counts 2 extra SQL statements from system tables. Therefore the total is either ActualNoOfIterations or ActualNoOfIterations + 2.
Assert.IsTrue(
BCPTSetupCard.BCPTLines.NoOfSQLStmts.AsInteger() in [ActualNoOfIterations, ActualNoOfIterations + 2],
StrSubstNo(UnexpectedNoOfSqlStmtsLbl, BCPTLogEntry.FieldCaption("No. of SQL Statements"), StrSubstNo('%1 or %2', ActualNoOfIterations, ActualNoOfIterations + 2), BCPTSetupCard.BCPTLines.NoOfSQLStmts.AsInteger()));
BCPTSetupCard.BCPTLines.AvgSQLStmts.AssertEquals(1);
BCPTSetupCard.Close();
end;
Expand Down
Loading