[master] [Subscription Billing] Infinite loop in CalculateBillingPeriod when HarmonizeNextBillingTo caps at stale "Next Billing To" date

[sanjmaurya]

AB#640056

Bug 640056: [master] [ALL-E][Subscription Billing] Infinite loop in CalculateBillingPeriod when HarmonizeNextBillingTo caps at stale "Next Billing To" date

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Agent} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

The new loop-progress guard (BillingPeriodEnd > PreviousBillingPeriodEnd) correctly prevents an infinite loop, but when it fires it exits silently: the var output parameter BillingPeriodEnd is left holding the non-advancing value returned by CalculateNextBillingToDateForServiceCommitment, and the caller receives no signal distinguishing a normal exit (billing date or end-date boundary reached) from an abnormal one (the inner function failed to advance the period).

In subscription billing, a silently incorrect BillingPeriodEnd can produce wrong invoice amounts or missed billing lines.

Recommendation:

• after the loop, detect the abnormal case — for example by checking whether the guard condition would have allowed another iteration but didn't — and raise an Error or emit a telemetry signal so the failure surface is observable.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

Copilot PR Review

Iteration 1 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

Findings by domain

Findings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).

Domain	Findings	Knowledge-backed	Agent	Inline	Fallback
Agent	1	0	1	1	0

Totals: 0 knowledge-backed · 1 agent findings.

Orchestrator pre-filter (13 file(s) excluded)

• layer-disabled (knowledge) : 13 file(s)

_{Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.}