Skip to content

fix for edge case when balance of a posting account at ending date is zero #8839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mynjj wants to merge 1 commit into
base: releases/28.0
Choose a base branch
from
+15 −13
Open

fix for edge case when balance of a posting account at ending date is zero #8839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions src/Apps/W1/ExcelReports/App/src/Financials/TrialBalance.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,12 +234,11 @@ codeunit 4410 "Trial Balance"
// And also in Net Change (which will have later the value at the starting date subtracted)
TrialBalanceData.Validate("Net Change", EXRTrialBalanceQuery.Amount);
TrialBalanceData.Validate("Net Change (ACY)", EXRTrialBalanceQuery.ACYAmount);
TrialBalanceData.CheckAllZero();
if not TrialBalanceData."All Zero" then begin
TrialBalanceData.Insert(true);
InsertUsedDimensionValue(1, TrialBalanceData."Dimension 1 Code", Dimension1Values);
InsertUsedDimensionValue(2, TrialBalanceData."Dimension 2 Code", Dimension2Values);
end;
// Every combination the query returns has entries, so it represents real activity and is kept even when it
// nets to zero. The second pass adjusts any that also have an opening balance.
TrialBalanceData.Insert(true);
InsertUsedDimensionValue(1, TrialBalanceData."Dimension 1 Code", Dimension1Values);
InsertUsedDimensionValue(2, TrialBalanceData."Dimension 2 Code", Dimension2Values);
end;
EXRTrialBalanceQuery.Close();

Expand All @@ -250,7 +249,9 @@ codeunit 4410 "Trial Balance"
TrialBalanceData.SetRange("G/L Account No.", EXRTrialBalanceQuery.AccountNumber);
TrialBalanceData.SetRange("Dimension 1 Code", EXRTrialBalanceQuery.DimensionValue1Code);
TrialBalanceData.SetRange("Dimension 2 Code", EXRTrialBalanceQuery.DimensionValue2Code);
if not TrialBalanceData.FindFirst() then begin // This shouldn't happen, but we consider it regardless
if not TrialBalanceData.FindFirst() then begin
// This shouldn't happen now that the first pass inserts every combination with entries up to the ending date, but we Init() and consider it regardless.
TrialBalanceData.Init();
TrialBalanceData."G/L Account No." := EXRTrialBalanceQuery.AccountNumber;
TrialBalanceData."Dimension 1 Code" := EXRTrialBalanceQuery.DimensionValue1Code;
TrialBalanceData."Dimension 2 Code" := EXRTrialBalanceQuery.DimensionValue2Code;
Expand Down Expand Up @@ -286,12 +287,11 @@ codeunit 4410 "Trial Balance"
TrialBalanceData.Validate("Balance (ACY)", EXRTrialBalanceBUQuery.ACYAmount);
TrialBalanceData.Validate("Net Change", EXRTrialBalanceBUQuery.Amount);
TrialBalanceData.Validate("Net Change (ACY)", EXRTrialBalanceBUQuery.ACYAmount);
TrialBalanceData.CheckAllZero();
if not TrialBalanceData."All Zero" then begin
TrialBalanceData.Insert(true);
InsertUsedDimensionValue(1, TrialBalanceData."Dimension 1 Code", Dimension1Values);
InsertUsedDimensionValue(2, TrialBalanceData."Dimension 2 Code", Dimension2Values);
end;
// Every combination the query returns has entries, so it represents real activity and is kept even when it
// nets to zero. The second pass adjusts any that also have an opening balance.
TrialBalanceData.Insert(true);
InsertUsedDimensionValue(1, TrialBalanceData."Dimension 1 Code", Dimension1Values);
InsertUsedDimensionValue(2, TrialBalanceData."Dimension 2 Code", Dimension2Values);
end;
EXRTrialBalanceBUQuery.Close();

Expand All @@ -304,6 +304,8 @@ codeunit 4410 "Trial Balance"
TrialBalanceData.SetRange("Dimension 2 Code", EXRTrialBalanceBUQuery.DimensionValue2Code);
TrialBalanceData.SetRange("Business Unit Code", EXRTrialBalanceBUQuery.BusinessUnitCode);
if not TrialBalanceData.FindFirst() then begin
// This shouldn't happen now that the first pass inserts every combination with entries up to the ending date, but we Init() and consider it regardless.
TrialBalanceData.Init();
TrialBalanceData."G/L Account No." := EXRTrialBalanceBUQuery.AccountNumber;
TrialBalanceData."Dimension 1 Code" := EXRTrialBalanceBUQuery.DimensionValue1Code;
TrialBalanceData."Dimension 2 Code" := EXRTrialBalanceBUQuery.DimensionValue2Code;
Expand Down
Loading