Refactor DirectLine to use RXJS v6 pipeable operators#102
Open
harshithkashyap wants to merge 1 commit intomicrosoft:masterfrom
Open
Refactor DirectLine to use RXJS v6 pipeable operators#102harshithkashyap wants to merge 1 commit intomicrosoft:masterfrom
harshithkashyap wants to merge 1 commit intomicrosoft:masterfrom
Conversation
harshithkashyap
force-pushed
the
rxjs-v6-upgrade
branch
from
fd9ceef to
3010edf
Compare
Author
|
@ckkashyap @compulim Request a review for the PR. |
Author
|
@compulim Would you please have a look at the PR and give me a review? |
harshithkashyap
force-pushed
the
rxjs-v6-upgrade
branch
from
fa4d866 to
38349e5
Compare
Closed
harshithkashyap
force-pushed
the
rxjs-v6-upgrade
branch
from
fc97196 to
d07459c
Compare
harshithkashyap
force-pushed
the
rxjs-v6-upgrade
branch
from
f0ee41d to
a118db9
Compare
harshithkashyap
force-pushed
the
rxjs-v6-upgrade
branch
3 times, most recently
from
157b93f to
c4a9ea0
Compare
harshithkashyap
force-pushed
the
rxjs-v6-upgrade
branch
3 times, most recently
from
267ff24 to
f62906d
Compare
harshithkashyap
force-pushed
the
rxjs-v6-upgrade
branch
2 times, most recently
from
37d8e5e to
c029b5d
Compare
harshithkashyap
force-pushed
the
rxjs-v6-upgrade
branch
3 times, most recently
from
5644c0e to
6110b26
Compare
Author
|
@stevengum @compulim Could you guys review this PR please? It's been open for over 2 years now and I've synced it with the latest changes as and when it's pushed to the main branch. We have been using this in production for a while now and haven't come across any errors with this refactor. The package is available to test at https://www.npmjs.com/package/botframework-directlinejs-tmp |
harshithkashyap
force-pushed
the
rxjs-v6-upgrade
branch
3 times, most recently
from
7f04b79 to
16d52e6
Compare
harshithkashyap
force-pushed
the
rxjs-v6-upgrade
branch
from
16d52e6 to
4a51764
Compare
harshithkashyap
force-pushed
the
rxjs-v6-upgrade
branch
from
4a51764 to
1e4e58b
Compare
harshithkashyap
force-pushed
the
rxjs-v6-upgrade
branch
2 times, most recently
from
6c96064 to
7c13bec
Compare
harshithkashyap
force-pushed
the
rxjs-v6-upgrade
branch
2 times, most recently
from
9c383fd to
5b1d339
Compare
… update webpack to v4 chore(npm): update dependencies, add tslint fix(directline): add missing commits post rebase docs(changelog): add message to change log, bump npm version fix(directline.interface): fix tslint errors fix(directline): add new changes from master refactor(app): remove dist directory chore(npm): update dependencies refactor(directline): remove unused imports chore(npm): update dependencies fix(directline): add new changes from master fix(changelog): remove duplicate entries fix(directline): add new changes from master test(directline): update failing tests to use rxjs v6 chore(npm): update dependencies fix(directline): remove unused files chore(npm): update dependencies fix(directline): add new changes from master chore(npm): update dependencies refactor(directline): update deprecated rxjs functions with new equivalent, fix failing tests fix(readme): correct typo fix(.gitignore): add missing newline at EOF fix(directline-mock): correct function, variables order fix(directline-streaming): import explicit named import from bfse refactor(directline): disable directline streaming export until Node.js packages are removed from botframework-streaming package chore(npm): update dependencies fix(webpack): replace deprecated webpack Visualizer plugin with BundleAnalyzerPlugin docs(directline): update streaming package comment fix(package): correct version, name chore(npm): update dependencies fix(tests): add directline streaming package back to fix failing tests chore(jsdom): update package feat(Activity): add adaptive card InvokeActivity type refactor(directline): add new changes from master chore(npm): update dependencies refactor(directline): add new changes from master chore(npm): update dependencies
harshithkashyap
force-pushed
the
rxjs-v6-upgrade
branch
from
5b1d339 to
2d487af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The above PR changes has been published to a temp npm package and can be installed by using
npm i botframework-directlinejs-tmp@1.1.5