fix: azd template validation pipeline issue#113
Merged
Prajwal-Microsoft merged 35 commits intomicrosoft:devfrom Mar 10, 2026
Merged
fix: azd template validation pipeline issue#113Prajwal-Microsoft merged 35 commits intomicrosoft:devfrom
Prajwal-Microsoft merged 35 commits intomicrosoft:devfrom
Conversation
fix: pipeline issue updated
fix: Psl bug 36265 pipeline2
fix: bicepparams changes to read env variable
run pipeline on dev merge
Priyanka-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft and
Roopan-Microsoft
as code owners
Priyanka-Microsoft
requested review from
Vinay-Microsoft,
aniaroramsft and
dgp10801
as code owners
…value accept array for admin value
…value fix: default value for admin capacity
fix: remove run on merge
infra/main.bicep
Outdated
|
|
||
| @description('Fabric capacity admin members') | ||
| param fabricCapacityAdmins array = [] | ||
| param fabricCapacityAdmins array = ['user@contoso.com'] |
Collaborator
There was a problem hiding this comment.
I asked to modify default value in document add you need to pass comma seperated values now.
Not required to modify in bicep file
…value fix: updated doc for fabric capacity admin value
Prajwal-Microsoft
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces improvements to the configuration and documentation for the project, focusing on making deployment more flexible and enhancing the clarity of the README. The most important changes include enabling environment-based configuration for Fabric capacity, updating workflow triggers, and reorganizing documentation for better usability.
Deployment and Configuration Improvements:
infra/main.bicepparamfile now reads thefabricCapacityModeandfabricCapacityAdminsvalues from environment variables, allowing for more flexible and dynamic deployments. This replaces hardcoded values, making it easier to customize deployments through workflow or local environment settings. [1] [2].github/workflows/azd-template-validation.ymlis updated to trigger on bothmainanddevbranches, and now passes thefabricCapacityModeas an environment variable to jobs, supporting the new dynamic configuration. [1] [2]Documentation Enhancements:
README.mdhas been reorganized with new sections for "Features," "Getting Started," "Guidance," and "Resources," making the documentation easier to navigate and more helpful for new users. [1] [2] [3] [4]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information