Skip to content

Remove the lifetime module from diskann-utils.#1275

Open
hildebrandmw wants to merge 1 commit into
mainfrom
mhildebr/lifetime
Open

Remove the lifetime module from diskann-utils.#1275
hildebrandmw wants to merge 1 commit into
mainfrom
mhildebr/lifetime

Conversation

@hildebrandmw

Copy link
Copy Markdown
Contributor

This utility is no longer needed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the diskann-utils “lifetime” utility module and its public WithLifetime API, simplifying the crate surface area by eliminating a no-longer-used abstraction.

Changes:

  • Delete diskann-utils/src/lifetime.rs (trait + helper types + unit tests).
  • Remove pub mod lifetime and pub use lifetime::WithLifetime from diskann-utils’ public exports.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
diskann-utils/src/lifetime.rs Deletes the lifetime-annotation utilities (WithLifetime, Static, Slice) and their tests.
diskann-utils/src/lib.rs Removes the lifetime module declaration and WithLifetime re-export from the crate root API.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread diskann-utils/src/lib.rs
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.47%. Comparing base (6caca35) to head (5a4853f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1275      +/-   ##
==========================================
- Coverage   91.50%   90.47%   -1.03%     
==========================================
  Files         498      497       -1     
  Lines       95522    95489      -33     
==========================================
- Hits        87407    86397    -1010     
- Misses       8115     9092     +977     
Flag Coverage Δ
miri 90.47% <ø> (-1.03%) ⬇️
unittests 90.14% <ø> (-1.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
diskann-utils/src/lib.rs 100.00% <ø> (ø)

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants