Use new tenants in performance benchmarks pipeline#25454
Merged
Conversation
github-actions
bot
added
area: build
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the performance benchmarks pipeline from using old tenant systems to new tenant management for ODSP testing. The changes implement a more dynamic tenant credential management system that provisions and cleans up tenants automatically.
- Replace hardcoded tenant variables with dynamic tenant provisioning using
trips-setuppackage - Add tenant credential cleanup after test completion
- Update pipeline logic to handle different credential sources based on endpoint type
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/pipelines/test-perf-benchmarks.yml | Updates main pipeline to use dynamic tenant credentials for ODSP tests and adds cleanup steps |
| tools/pipelines/templates/include-test-perf-benchmarks.yml | Adds tenant setup logic for ODSP endpoint using Azure CLI and trips-setup package |
| set -eu -o pipefail | ||
|
|
||
| # Increase the maximum time to wait for a tenant to 1 hour to accommodate multiple test runs at the same time. | ||
| npx --package=@ff-internal/trips-setup@0.0.5 -- trips-setup --waitTime=3600 --accessToken=$SYSTEM_ACCESSTOKEN |
There was a problem hiding this comment.
[nitpick] The hardcoded wait time of 3600 seconds (1 hour) should be extracted to a parameter or variable to make it configurable and easier to adjust without code changes.
Abe27342
approved these changes
Sep 16, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Abe27342
approved these changes
Sep 16, 2025
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
Continue removing uses of the old tenants and migrating to the new tenant system. [AB#45635](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/45635) --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue removing uses of the old tenants and migrating to the new tenant system.
AB#45635