Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the publicNetworkAccessEnabled feature to block public traffic for tenants with this setting disabled. The changes implement validation logic that checks tenant configuration and returns an error when public network access is disabled.
- Add validation for
publicNetworkAccessEnabledin tenant custom data - Return appropriate error messages when public network access is disabled
- Implement consistent behavior across both HTTP services and network helper modules
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| server/routerlicious/packages/services-shared/src/http.ts | Adds public network access validation in the validatePrivateLink function |
| server/routerlicious/packages/lambdas/src/nexus/networkHelper.ts | Adds public network access validation in the checkNetworkInformation function |
server/routerlicious/packages/lambdas/src/nexus/networkHelper.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
pradeepvairamani
approved these changes
Sep 23, 2025
pradeepvairamani
approved these changes
Sep 23, 2025
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
Add publicNetworkAccessEnabled to block the public traffic for the tenant which has the publicNetworkAccessEnabled as false --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add publicNetworkAccessEnabled to block the public traffic for the tenant which has the publicNetworkAccessEnabled as false