Skip to content

Improve 'copy devDependencies' step of include-test-real-service.yml#25543

Merged
Abe27342 merged 2 commits intomainfrom
test/absander/minimize-dev-deps
Sep 25, 2025
Merged

Improve 'copy devDependencies' step of include-test-real-service.yml#25543
Abe27342 merged 2 commits intomainfrom
test/absander/minimize-dev-deps

Conversation

@Abe27342
Copy link
Contributor

@Abe27342 Abe27342 commented Sep 25, 2025

Description

Follow-up to #25535: in line with using a "host repository" that has package-lock'd internal dependencies, tighten the "copy devDependency" script that we use to get devDependencies necessary at workload runtime to exclude some common dependencies that are only used at build time.

This is motivated by still seeing some DDS fuzz harness pipeline failures due to recently published transitive dependencies of build-tools.

Test run: here

Copilot AI review requested due to automatic review settings September 25, 2025 00:03
@github-actions github-actions bot added the area: build Build related issues label Sep 25, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the 'copy devDependencies' step in the test-real-service pipeline by adding selective filtering and better handling of dependency copying. The changes enhance the robustness and efficiency of the CI/CD process for real service testing.

  • Added logic to selectively exclude build-time dependencies when copying devDependencies
  • Improved handling of existing devDependencies to avoid overwriting
  • Added detailed comments explaining the purpose and rationale

@github-actions github-actions bot added the base: main PRs targeted against main branch label Sep 25, 2025
@Abe27342 Abe27342 merged commit a9ebb8d into main Sep 25, 2025
36 of 37 checks passed
@Abe27342 Abe27342 deleted the test/absander/minimize-dev-deps branch September 25, 2025 17:10
anthony-murphy-agent pushed a commit to anthony-murphy-agent/FluidFramework that referenced this pull request Jan 14, 2026
…icrosoft#25543)

## Description

Follow-up to microsoft#25535: in line with using a "host repository" that has
package-lock'd internal dependencies, tighten the "copy devDependency"
script that we use to get devDependencies necessary at workload runtime
to exclude some common dependencies that are only used at build time.

This is motivated by still seeing some DDS fuzz harness pipeline
failures due to recently published transitive dependencies of
build-tools.

Test run:
[here](https://dev.azure.com/fluidframework/internal/_build/results?buildId=357194&view=logs&j=bbaafa3d-c204-5f81-4508-786dc29a3642&t=f302f968-fb15-5cb8-d0fb-0d951f384806)

---------

Co-authored-by: Abram Sanderson <absander@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: build Build related issues base: main PRs targeted against main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants