Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the test infrastructure to support ODSP TRIPS tenants for odspdf stress runs by adding proper tenant type configuration and refactoring parameters for better clarity.
- Adds
odspTenantTypeparameter to distinguish between prod and dogfood ODSP tenants - Replaces hardcoded stage-based logic with explicit
lockBehaviorparameter - Updates TRIPS setup and cleanup commands to accept tenant type parameters
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/pipelines/test-real-service.yml | Adds repository reference and configures lock behavior and tenant types for test stages |
| tools/pipelines/test-real-service-stress.yml | Adds repository reference, configures tenant types for stress tests, and removes hardcoded stage variables |
| tools/pipelines/test-perf-benchmarks.yml | Adds repository reference for ff_pipeline_host |
| tools/pipelines/test-dds-stress.yml | Adds repository reference for ff_pipeline_host |
| tools/pipelines/templates/include-test-real-service.yml | Major refactoring to support parameterized tenant types and lock behavior instead of hardcoded stage logic |
| - release/* | ||
| - main | ||
| - next | ||
| repositories: |
There was a problem hiding this comment.
Adding these blocks to the pipelines that use ff_pipeline_host allows proper testing of changes to that repo before we check them in, since it means you can queue one of these pipelines while referencing a specific branch in that repository rather than being forced to use main. This is similar to the kind of thing we do for selecting the specific run of 'Build - client packages' when queueing the secondary pipelines.
## Description #25599 updated the include-test-real-service template to use a repository reference rather than an explicit checkout. This reference needs to exist on all pipelines that use it, but this one was missed. Co-authored-by: Abram Sanderson <absander@microsoft.com>
## Description Updates `include-test-real-service` to support odspdf TRIPS tenants. I did some minor refactoring for parameter clarity while in the area. Test runs: - e2e tests before trips-setup package update in the host repo [here](https://dev.azure.com/fluidframework/internal/_build/results?buildId=358461&view=results) (unaffected, as it should be) - Stress run using updated trips-setup [here](https://dev.azure.com/fluidframework/internal/_build/results?buildId=358690&view=results) --------- Co-authored-by: Abram Sanderson <absander@microsoft.com>
## Description microsoft#25599 updated the include-test-real-service template to use a repository reference rather than an explicit checkout. This reference needs to exist on all pipelines that use it, but this one was missed. Co-authored-by: Abram Sanderson <absander@microsoft.com>
Description
Updates
include-test-real-serviceto support odspdf TRIPS tenants.I did some minor refactoring for parameter clarity while in the area.
Test runs: