Fix Bohemia integration pipeline: use console.log instead of console.warn or console.error#25649
Closed
yann-achard-MS wants to merge 2 commits intomainfrom
Closed
Fix Bohemia integration pipeline: use console.log instead of console.warn or console.error#25649yann-achard-MS wants to merge 2 commits intomainfrom
yann-achard-MS wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a Bohemia integration pipeline issue by changing the assert function to use console.log instead of console.error for logging assertion failures. The change addresses a dependency where the Bohemia repo relies on the current implementation not calling console.error/warn.
- Replaced
console.errorwithconsole.login the assertion failure logging - Added explanatory comment about the reason for using
console.log
Contributor
Author
|
Superseded by #25652. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the build integration pipeline error encountered here.
The Bohemia repo uses our
assertfunction and takes a dependency on its current implementation (specifically, the fact that it does not callconsole.error/warn). This is not something we want to support. Theassertfunction is legacy beta since we haven't gone through the process of making it internal, but no FF consumer should not be using it.Breaking Changes
None