Conversation
…Runtime.submitMessage and MockFluidDataStoreRuntime.submitMessage
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated submitMessage method from both FluidDataStoreRuntime and MockFluidDataStoreRuntime classes, marking a breaking change. Users should migrate to using IFluidDataStoreContext.submitMessage instead.
Key Changes:
- Removal of deprecated
submitMessagemethods from production and test runtime classes - Updates to type validation configuration to mark backward compatibility as broken
- Addition of changeset documenting the breaking change
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/runtime/datastore/src/dataStoreRuntime.ts | Removes the deprecated submitMessage method from FluidDataStoreRuntime |
| packages/runtime/test-runtime-utils/src/mocks.ts | Removes the deprecated submitMessage method from MockFluidDataStoreRuntime |
| packages/runtime/datastore/api-report/datastore.legacy.beta.api.md | Updates API report to reflect removal of submitMessage from public API |
| packages/runtime/test-runtime-utils/api-report/test-runtime-utils.legacy.beta.api.md | Updates API report to reflect removal of submitMessage from mock runtime |
| packages/runtime/datastore/package.json | Marks FluidDataStoreRuntime class backward compatibility as broken |
| packages/runtime/test-runtime-utils/package.json | Marks MockFluidDataStoreRuntime class backward compatibility as broken |
| packages/runtime/datastore/src/test/types/validateDatastorePrevious.generated.ts | Adds TypeScript error suppression for expected breaking compatibility |
| packages/runtime/test-runtime-utils/src/test/types/validateTestRuntimeUtilsPrevious.generated.ts | Adds TypeScript error suppression for expected breaking compatibility |
| packages/framework/aqueduct/src/test/types/validateAqueductPrevious.generated.ts | Adds TypeScript error suppression for transitive breaking compatibility |
| packages/framework/aqueduct/package.json | Marks DataObjectFactoryProps interface backward compatibility as broken |
| .changeset/odd-loops-flash.md | Documents the breaking change with migration guidance |
| "@fluidframework/test-runtime-utils": minor | ||
| "__section": breaking | ||
| --- | ||
| Remove submitMessage from FluidDataStoreRuntime and MockFluidDataStoreRuntime |
Contributor
There was a problem hiding this comment.
🚫 [vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'submitMessage'?
Contributor
|
🔗 Found some broken links! 💔 Run a link check locally to find them. See linkcheck output |
jzaffiro
approved these changes
Oct 27, 2025
This was referenced Oct 27, 2025
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
…Runtime.submitMessage (microsoft#25755) remove FluidDataStoreRuntime.submitMessage and MockFluidDataStoreRuntime.submitMessage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove FluidDataStoreRuntime.submitMessage and MockFluidDataStoreRuntime.submitMessage