feat(container-loader): structured concurrency with effection for connection retry loops#26406
Draft
tylerbutler wants to merge 1 commit intomicrosoft:mainfrom
Draft
feat(container-loader): structured concurrency with effection for connection retry loops#26406tylerbutler wants to merge 1 commit intomicrosoft:mainfrom
tylerbutler wants to merge 1 commit intomicrosoft:mainfrom
Conversation
tylerbutler
changed the title
Replace manual AbortController/setTimeout-based async lifecycle management in ConnectionManager with effection 4.0 generator-based Operations. - Convert connectCore() retry loop to *retryConnectOperation() generator using yield* call() and yield* sleep() instead of await/setTimeout - Convert reconnect() to *reconnectOperation() generator - Replace IPendingConnection.abort() with Task.halt() for cancellation - Update all callers (reconnectOnError, sendMessages, beforeProcessingIncomingOp) to use run(() => reconnectOperation(...)) - Add try-catch around storageOnly path in connect() for error parity - Adjust test to use clock.tickAsync(0) for effection microtask flushing
tylerbutler
force-pushed
the
feat/effection-connection-manager
branch
from
a1c0562 to
057459c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AbortController/setTimeout/Promisewiring inconnectCore()with a*retryConnectOperation()generator usingyield* call()andyield* sleep()reconnect()method with a*reconnectOperation()generator using the same effection primitivesTask.halt()instead ofAbortController.abort()— the generator simply stops at the next yield pointAbortControllersetup, no manualabortSignal.abortedchecks, nonew Promise(resolve => setTimeout(resolve, delayMs))patternsAll external APIs remain unchanged.
Test plan