ci: Choose correct path to tinylicious.log depending on realsvc or stress tests#26415
Open
alexvy86 wants to merge 2 commits intomicrosoft:mainfrom
Open
ci: Choose correct path to tinylicious.log depending on realsvc or stress tests#26415alexvy86 wants to merge 2 commits intomicrosoft:mainfrom
alexvy86 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the client build pipeline template to upload tinylicious.log from the correct package directory depending on whether the run is for real-service tinylicious tests or stress tinylicious tests, avoiding artifact-upload warnings in CI.
Changes:
- Passes the current
test.nameinto the “Upload tinylicious log” Bash task viaTEST_NAME. - Adds Bash logic to select the correct package directory (
test-end-to-end-testsvstest-service-load) before uploadingtinylicious.log.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently when we run the stress tests against tinylicious (in the build pipeline, not in the separate pipeline for stress tests), the step to upload the tinylicious log to the pipeline artifacts logs a warning because it's looking for the log file in the wrong place (the path where the file ends up in when the real-svc tests run, but not when the stress tests run).
This adds logic to look for the log file in the correct place in each case.
Reviewer Guidance
The review process is outlined on this wiki page.
Run from this PR demonstrates the log file is now uploaded correctly for the stress tests and for the real-svc tests.
I deliberately did not try to check for the exact test script being run (e.g.
ci:test:realsvc:tinyliciousVSci:test:stress:tinylicious) to avoid future issues if we change the script names. The new logic could potentially also break during a drastic rename, but I think has a better chance of surviving a small script name refactor.