Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the test skip logic for RefreshSerializerLifeCycle.spec.ts to run the entire test suite only on local servers. Previously, tests were conditionally skipped on non-local servers only when useLoadingGroupIdForSnapshotFetch was enabled. The PR description indicates these tests are flaky on different servers due to timeouts, and unit tests were added after SnapshotRefresher creation to provide coverage when the E2E test suite is skipped.
Changes:
- Simplified conditional skip logic to unconditionally skip all test variations on non-local servers
- Retained the
useLoadingGroupIdForSnapshotFetchconfiguration parameter for local test runs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RefreshSerializerLifeCycle.spec.ts tests are still flaky running in different servers due to timeouts. I still find useful to run this tests locally. Unit tests were added after SnapshotRefresher creation to mitigate some of the missing coverage when we skipped this test suite.