test(tree): Re-enable commented-out table benchmarks#27227
Open
Josmithr wants to merge 3 commits intomicrosoft:mainfrom
Open
test(tree): Re-enable commented-out table benchmarks#27227Josmithr wants to merge 3 commits intomicrosoft:mainfrom
Josmithr wants to merge 3 commits intomicrosoft:mainfrom
Conversation
… row removal on columns" This reverts commit 4160469.
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (746 lines, 2 files), I've queued these reviewers:
How this works
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-enables previously commented-out SharedTree “table” benchmarks (both duration and memory) related to undo/redo scenarios, aligning with AB#43364.
Changes:
- Re-enabled multiple undo/redo benchmark cases in the execution-time suite for table operations (insert/remove column/row, including combined scenarios).
- Re-enabled corresponding redo-focused memory-usage benchmarks for similar table operation patterns.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| packages/dds/tree/src/test/shared-tree/tableTree.bench.ts | Re-enables several previously disabled duration benchmarks for undo/redo table operations. |
| packages/dds/tree/src/test/memory/tableTree.spec.ts | Re-enables several previously disabled memory benchmarks for redo (and related) table operations. |
Comment on lines
+419
to
+451
| runBenchmark({ | ||
| title: `Redo: Remove a column and a row in the middle ${count} times`, | ||
| tableSize, | ||
| initialCellValue, | ||
| beforeOperation: (table, undoRedoManager) => { | ||
| for (let i = 0; i < count; i++) { | ||
| const column = table.columns[Math.floor(table.columns.length / 2)]; | ||
| const row = table.rows[Math.floor(table.rows.length / 2)]; | ||
| table.removeColumns([column]); | ||
| table.removeRows([row]); | ||
| } | ||
| for (let i = 0; i < count; i++) { | ||
| // Undo remove row | ||
| undoRedoManager.undo(); | ||
| // Undo remove column | ||
| undoRedoManager.undo(); | ||
| } | ||
| assert(!undoRedoManager.canUndo); | ||
| assert(undoRedoManager.canRedo); | ||
| }, | ||
| operation: (_table, undoRedoManager) => { | ||
| for (let i = 0; i < count; i++) { | ||
| // Redo remove row | ||
| undoRedoManager.redo(); | ||
| // Redo remove column | ||
| undoRedoManager.redo(); | ||
| } | ||
| }, | ||
| afterOperation: (_table, undoRedoManager) => { | ||
| assert(!undoRedoManager.canRedo); | ||
| }, | ||
| maxBenchmarkDurationSeconds, | ||
| }); |
Comment on lines
+441
to
+444
| // Redo remove row | ||
| undoRedoManager.redo(); | ||
| // Redo remove column | ||
| undoRedoManager.redo(); |
| undoRedoManager.undo(); | ||
| undoRedoManager.undo(); | ||
| } | ||
| assert(!undoRedoManager.canUndo); |
| // Undo column insertion | ||
| undoRedoManager.undo(); | ||
| } | ||
| assert(!undoRedoManager.canUndo); |
| for (let i = 0; i < count; i++) { | ||
| undoRedoManager.undo(); | ||
| } | ||
| assert(!undoRedoManager.canUndo); |
| // Undo column removal | ||
| undoRedoManager.undo(); | ||
| } | ||
| assert(!undoRedoManager.canUndo); |
| // Undo column insertion | ||
| undoRedoManager.undo(); | ||
| } | ||
| assert(!undoRedoManager.canUndo); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AB#43364