adds core dependency back for non-winml package#701
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
baijumeswani
previously approved these changes
May 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Restores the .NET SDK’s dependency on the non-WinML Core NuGet package so consumers of Microsoft.AI.Foundry.Local (non-WinML variant) reliably bring in the Core runtime after the netstandard2.0 support work.
Changes:
- Add a conditional
PackageReferencetoMicrosoft.AI.Foundry.Local.CorewhenUseWinML=false. - Keep
Microsoft.AI.Foundry.Local.Core.WinMLas the dependency whenUseWinML=true.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
baijumeswani
previously approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
was likely removed during netstandard2.0 support work #629