Try adding serveral Operators to the IR#678
Open
YanjieGao wants to merge 5 commits intomicrosoft:masterfrom
YanjieGao:master
Open
Try adding serveral Operators to the IR#678YanjieGao wants to merge 5 commits intomicrosoft:masterfrom YanjieGao:master
YanjieGao wants to merge 5 commits intomicrosoft:masterfrom
YanjieGao:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try adding several OPs (Follow ONNX) to the IR. Please verify the standard.
Plan:
1 keep the legacy IR file ops.pbtxt
2 add new op (Not in legacy ops.pbtxt) at ops_extend.pbtxt which not in ops.pbtxt. This phase will merge onnx operators.
Exclude op below:
legacy_operator_set = ["Add", "AveragePool", "BatchNormalization", "Concat", "Conv", "ConvTranspose", "Div", "Dropout", "Elu",
"Exp", "Flatten", "GRU", "Gather", "Gemm", "GlobalAveragePool", "GlobalMaxPool", "LRN", "LSTM", "LeakyRelu", "Log", "MatMul",
"Mul", "Pad", "RNN", "Reciprocal", "Relu", "Reshape", "Sigmoid", "Slice", "Softmax", "Split", "Sequeeze", "Sub", "Tanh"]
3 Future new IR op will add to ops_extend.pbtxt
4 When the legacy IR plan want to update, it needs to be updated with the pbtxt file, parser and emit, and then updated.