fix: MSBuild process output encoding#155
Open
hikarin522 wants to merge 1 commit intomicrosoft:masterfrom
Open
Conversation
Fixed encoding of strings received from MSBuild process.
Member
|
Not sure I understand the issue this is fixing... |
Member
|
Thanks for the contribution @hikarin522! Will you add a comment explaining why this is needed? I guess it is trying to match the text encoding to whatever Unity is using? What happens when that is not done? |
Author
|
If the system language is Japanese, MSBuild will be output as CP932, which will cause garbled characters. |
Author
|
Below is an image of a PackageReference typo error.
|
ryantrem
approved these changes
Jan 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed encoding of strings received from MSBuild process.