Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes several minor code cleanups and improvements across both backend and frontend code, as well as test files. The main changes involve removing unused state variables, improving code clarity, and ensuring proper superclass initialization in test page objects.
Frontend state management cleanup:
selectedFileContentstate and its associated setter frombatchView.tsx, and stopped setting it when fetching file data. (src/frontend/src/pages/batchView.tsx) [1] [2]progressPercentagestate frommodernizationPage.tsxand updated the loading timeout logic to no longer depend on it. (src/frontend/src/pages/modernizationPage.tsx) [1] [2]Backend and test improvements:
comms_manager.py, explicitly returnsNonewhen no matching agent is found, clarifying intent. (src/backend/sql_agents/helpers/comms_manager.py)src/tests/backend/sql_agents/convert_script_test.py)Test page object consistency:
HomePageandLoginPagetest classes to callsuper().__init__(page)instead of settingself.pagedirectly, ensuring proper base class initialization. (tests/e2e-test/pages/HomePage.py,tests/e2e-test/pages/loginPage.py) [1] [2]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information