fix: Merging Dev v4 changes to main by Priyanka-Microsoft · Pull Request #783 · microsoft/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator

Priyanka-Microsoft · 2026-01-27T04:45:57Z

Purpose

...
This pull request primarily introduces a .coveragerc configuration file to manage code coverage reporting, and makes minor adjustments to package initialization files. The main focus is on improving test coverage management and cleaning up unnecessary docstrings.

Test coverage configuration:

Added a .coveragerc file to configure code coverage measurement, specifying which files and directories to include or omit, and setting up reporting rules.

Package initialization cleanup:

Added minimal __init__.py files to src/ and src/backend/ to mark them as Python packages. [1] [2]
Removed an unnecessary docstring from src/tests/mcp_server/__init__.py to clean up the test package initialization.

Does this introduce a breaking change?

Yes
No

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check

Verify that the following are valid

...

Other Information

- Implemented unit tests for the OrchestrationManager class to ensure proper functionality. - Mocked external dependencies including Azure services and agent framework components. - Covered various scenarios including orchestration initialization, agent creation, and event processing. - Added tests for error handling in orchestration execution and WebSocket communication. - Ensured proper participant mapping and workflow execution in orchestration methods.

…st coverage command

…refine pytest command

…les mocking with MagicMock and removing platform-specific skip markers.

… on Linux

…and clarity. Update test cases to ensure proper environment setup and enhance coverage for user language endpoint functionality.

…mocking compatibility issues

…ve platform-specific skip markers and enhance mock setup for cross-platform compatibility.

…patibility issues

…erage for user language endpoint functionality

…pp.py test execution

…ution

…letion message is displayed

…ut handling

…suppress unnecessary output

…the workflow

…eporting

…erter to use real classes for improved type handling and consistency

- Implemented unit tests for the OrchestrationManager class to ensure proper functionality. - Mocked external dependencies including Azure services and agent framework components. - Covered various scenarios including orchestration initialization, agent creation, and event processing. - Ensured error handling and edge cases are tested, including failures in client and manager creation. - Verified that orchestration runs correctly with different input types and handles WebSocket errors gracefully.

…path definitions

test: Macae v4 unittestcases kd

src/tests/backend/v4/magentic_agents/models/test_agent_models.py

src/tests/backend/common/database/test_database_base.py

src/tests/backend/common/config/test_app_config.py

src/tests/backend/v4/magentic_agents/test_foundry_agent.py

src/tests/backend/v4/orchestration/test_human_approval_manager.py

src/tests/backend/v4/common/services/test_plan_service.py

+        """Test that event tracking is called appropriately."""
+        # This test verifies the event tracking integration
+        with patch.object(mock_event_utils, 'track_event_if_configured') as mock_track:
+            mock_approval = MockPlanApprovalResponse(


src/tests/backend/common/utils/test_otlp_tracing.py

src/tests/backend/v4/magentic_agents/test_proxy_agent.py

src/tests/backend/v4/common/services/test_team_service.py

fix: fixed code quality issues

fix: fixed code quality issue

fix: fixed copilot suggestions

src/tests/backend/v4/orchestration/test_human_approval_manager.py

src/tests/backend/v4/config/test_settings.py

src/tests/backend/auth/conftest.py

src/tests/backend/v4/magentic_agents/models/test_agent_models.py

src/tests/backend/v4/config/test_agent_registry.py

src/tests/backend/v4/common/services/test_agents_service.py

fix: fixed new suggestions by copilot

src/tests/backend/common/config/test_app_config.py

+import pytest
+import os
+import logging
+from unittest.mock import patch, MagicMock, AsyncMock


src/tests/backend/common/config/test_app_config.py

+import os
+import logging
+from unittest.mock import patch, MagicMock, AsyncMock
+from azure.identity import DefaultAzureCredential, ManagedIdentityCredential


src/tests/backend/common/config/test_app_config.py

+import logging
+from unittest.mock import patch, MagicMock, AsyncMock
+from azure.identity import DefaultAzureCredential, ManagedIdentityCredential
+from azure.cosmos import CosmosClient


src/tests/backend/common/config/test_app_config.py

+from unittest.mock import patch, MagicMock, AsyncMock
+from azure.identity import DefaultAzureCredential, ManagedIdentityCredential
+from azure.cosmos import CosmosClient
+from azure.ai.projects.aio import AIProjectClient


src/tests/backend/auth/test_auth_utils.py

+import pytest
+import base64
+import json
+import logging


src/tests/backend/auth/test_auth_utils.py

+import logging
+import sys
+import os
+import importlib.util


src/tests/backend/v4/common/services/test_base_api_service.py

+import sys
+import importlib.util
+from unittest.mock import patch, MagicMock, AsyncMock, Mock
+from typing import Any, Dict, Optional, Union


src/tests/backend/common/database/test_cosmosdb.py

Copilot

Pull request overview

This pull request merges v4 development changes into the main branch, primarily focusing on test infrastructure improvements and minor code cleanup. The changes introduce comprehensive test coverage configuration, add extensive unit tests for backend services, and remove unused code and imports from both frontend and backend components.

Changes:

Added .coveragerc configuration file for test coverage management
Created extensive unit tests for v4 backend services (agents, orchestration, API services)
Removed unused imports and commented-out code from frontend and backend
Updated GitHub Actions workflow to use the new coverage configuration
Added package initialization files for proper Python module structure

Reviewed changes

Copilot reviewed 46 out of 53 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`.coveragerc`	Configures code coverage reporting, excluding test directories and specifying source paths
`.github/workflows/test.yml`	Updates test workflow to use new coverage config and enforce 80% coverage threshold
`src/__init__.py`, `src/backend/__init__.py`	Package initialization files for proper Python module structure
`src/tests/backend/v4/*/.py`	New comprehensive test files for v4 backend components including agents, services, and API endpoints
`src/backend/v4/api/router.py`	Adds missing return statements to API endpoints
`src/frontend/src/*/.tsx`	Removes unused imports and conditional rendering in frontend components
`src/backend/v4/magentic_agents/common/lifecycle.py`	Removes commented-out cleanup code
`src/backend/v4/common/services/team_service.py`	Removes commented-out user verification code

Comments suppressed due to low confidence (1)

src/frontend/src/components/common/TeamSelector.tsx:1

The removal of the conditional wrapper {tempSelectedTeam && (...)} around the dialog actions means the "Continue" button is now always rendered, even when no team is selected. While the button is properly disabled via the disabled prop, this changes the UX by showing a disabled button instead of hiding it. Ensure this is the intended behavior.

import React, { useState } from 'react';

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/backend/v4/api/router.py

Copilot

Pull request overview

Copilot reviewed 46 out of 53 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/frontend/src/components/common/TeamSelector.tsx:1

The removal of the conditional wrapper {tempSelectedTeam && (...)} means the Continue button will now always be rendered, even when tempSelectedTeam is null/undefined. This could lead to unexpected UI behavior since the button is disabled but still visible. Consider whether the button should be hidden entirely when no team is selected, or if the current approach of showing a disabled button is the desired behavior.

import React, { useState } from 'react';

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/backend/v4/api/router.py

github-actions · 2026-03-02T05:49:38Z

🎉 This PR is included in version 4.0.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Dhruvkumar-Microsoft and others added 30 commits December 10, 2025 10:43

created the unit testcases

49862b0

added the changes

88fd995

Refactor test files and remove empty __init__.py files; streamline te…

ab41f19

…st coverage command

Add dev-v4 branch to workflow triggers

9f57a38

Update workflow triggers to include macae-v4-unittestcases-kd branch

caefaa5

Update workflow triggers to include additional branches for testing

e2b8029

Update test workflow to include macae-v4-unittestcases-kd branch and …

e8edfb0

…refine pytest command

Add macae-v4-unittestcases-kd branch to workflow triggers

a87eefb

Refine pytest command in test workflow to simplify coverage reporting

9644c93

Add platform-specific skip marker for tests using sys.modules mocking

c08079e

Refactor tests for cross-platform compatibility by replacing sys.modu…

baa07a6

…les mocking with MagicMock and removing platform-specific skip markers.

Add platform-specific skip marker for tests using sys.modules mocking…

12bf2a8

… on Linux

Refactor import statements in app.py and test_app.py for consistency …

dd70537

…and clarity. Update test cases to ensure proper environment setup and enhance coverage for user language endpoint functionality.

Add platform-specific skip markers for Linux in test cases to handle …

90f9d77

…mocking compatibility issues

Refactor test cases in test_app.py and test_agent_registry.py to remo…

c6a7b3d

…ve platform-specific skip markers and enhance mock setup for cross-platform compatibility.

Add platform check for test skipping on Linux due to Mock/FastAPI com…

8315bbe

…patibility issues

Refactor test workflow to run app.py tests separately and enhance cov…

eac9ec0

…erage for user language endpoint functionality

Refactor test workflow to improve coverage reporting and streamline a…

ebf39b7

…pp.py test execution

Add quiet flag to pytest commands for cleaner output during test exec…

e5db332

…ution

Suppress output of app.py tests in CI workflow for cleaner logs

b380112

Enhance app.py test execution by suppressing output and ensuring comp…

9a158aa

…letion message is displayed

Refactor test workflow to run backend tests together and improve outp…

6a6e354

…ut handling

Capture pytest output for backend tests and report coverage

dcca12e

Refactor backend test execution to streamline coverage reporting and …

a749bd2

…suppress unnecessary output

Capture pytest output for backend tests and display the last line in …

4551f12

…the workflow

Update test workflow to refine branch triggers and enhance coverage r…

fcbb1b9

…eporting

Add 'macae-v4-unittestcases-kd' branch to push triggers in test workflow

5273a37

Update references to Bicep files in next-steps.md for consistency

7967b35

Update references to Bicep files in next-steps.md for accuracy

bc4bc97

Kingshuk-Microsoft and others added 6 commits January 28, 2026 16:50

Refactor mocking of v4.models in test settings and plan_to_mplan_conv…

19fd09d

…erter to use real classes for improved type handling and consistency

Update test workflow to include demo-v4 branch and ensure consistent …

99b966b

…path definitions

Remove macae-v4-unittestcases-kd branch from test workflow triggers

6577ea0

Add quiet mode to pytest command in test workflow for cleaner output

bdd15df

Merge pull request #790 from microsoft/macae-v4-unittestcases-kd

49a54da

test: Macae v4 unittestcases kd

github-advanced-security bot found potential problems Jan 29, 2026

View reviewed changes

src/tests/backend/v4/magentic_agents/models/test_agent_models.py Fixed Show fixed Hide fixed

github-code-quality bot found potential problems Jan 29, 2026

View reviewed changes

Roopan-Microsoft and others added 3 commits January 30, 2026 11:49

Merge pull request #777 from microsoft/psl-codeql

3b5043b

fix: fixed code quality issues

macae-v4-fix

6c005a6

test: macae-v4-fix-stabilize-test-cases

5543104

Roopan-Microsoft previously approved these changes Feb 2, 2026

View reviewed changes

Kanchan-Microsoft and others added 2 commits February 2, 2026 16:13

pushed fix for code quality

9ede715

Merge pull request #793 from microsoft/psl-codefix

cf11055

fix: fixed code quality issue

Roopan-Microsoft dismissed their stale review via cf11055 February 2, 2026 10:54

Kanchan-Microsoft and others added 2 commits February 3, 2026 09:39

fixed copilot suggestions

09d8068

Merge pull request #794 from microsoft/psl-codefix

b92a822

fix: fixed copilot suggestions

github-code-quality bot found potential problems Feb 3, 2026

View reviewed changes

Kanchan-Microsoft and others added 2 commits February 3, 2026 10:46

fixed new suggestions

f4d5ea7

Merge pull request #796 from microsoft/psl-codefix

ff6e18d

fix: fixed new suggestions by copilot

github-code-quality bot found potential problems Feb 3, 2026

View reviewed changes

Kanchan-Microsoft requested a review from Copilot February 3, 2026 06:04

Copilot AI reviewed Feb 3, 2026

View reviewed changes

src/backend/v4/api/router.py Show resolved Hide resolved

src/backend/v4/api/router.py Show resolved Hide resolved

Kanchan-Microsoft requested a review from Copilot February 3, 2026 06:16

Copilot AI reviewed Feb 3, 2026

View reviewed changes

src/backend/v4/api/router.py Show resolved Hide resolved

Roopan-Microsoft approved these changes Feb 3, 2026

View reviewed changes

Avijit-Microsoft approved these changes Feb 3, 2026

View reviewed changes

Roopan-Microsoft merged commit 38194fb into main Feb 3, 2026
10 checks passed

github-actions bot added the released label Mar 2, 2026

Conversation

Priyanka-Microsoft commented Jan 27, 2026

Purpose

Does this introduce a breaking change?

How to Test

What to Check

Other Information

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants