factor out batch_invert #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the batch_invert function by moving it from src/spartan/ppsnark.rs to src/spartan/mod.rs, making it available as a reusable utility function across the codebase. This eliminates code duplication by replacing a local closure implementation in src/provider/ipa_pc.rs with the centralized version.
Changes:
- Moved
batch_invertandbatch_invert_serialfunctions tosrc/spartan/mod.rsfor reuse - Updated imports in
src/spartan/ppsnark.rsandsrc/provider/ipa_pc.rsto use the centralized function - Simplified test module structure by removing unnecessary nesting
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/spartan/mod.rs | Added batch_invert and batch_invert_serial as public utility functions with documentation |
| src/spartan/ppsnark.rs | Removed local implementation, added import, simplified test module structure |
| src/provider/ipa_pc.rs | Removed local closure implementation, added import of centralized function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
srinathsetty
force-pushed
the
batch_invert
branch
from
89db9b4 to
9f335e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.