Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conda tests:
github actions image don't have conda in it, hence skipped the tests.
Yarn test:
CanBuildAndRunNodeAppWithoutWorkspace_UsingYarn2ForBuild
the next version in sample app is incompatible with node version

With node 20:

Lerna tests:
GeneratesScript_AndBuildMonorepoAppUsingLerna_Yarn
GeneratesScript_AndBuildMonorepoAppUsingLerna_Npm
GeneratesScript_AndBuilds_UsingSuppliedPackageDir_WhenPackageDirAndSourceDirAreSame
For Lerna-based monorepo apps, InstallLernaCommand (npm install --global lerna or npm install --global lerna --no-package-lock) is set in NodePlatform.cs but never executed in NodeBashBuildSnippet.sh.tpl before running lerna commands, causing 'lerna: command not found' errors
After installing lerna command

lerna commands executed.
This code path is never used by any app, skipping the test for now.