-
Notifications
You must be signed in to change notification settings - Fork 59
Add basic pytest suite #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rosscutler
wants to merge
1
commit into
master
Choose a base branch
from
codex/improve-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| import os | ||
| import sys | ||
| sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), '..'))) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import pandas as pd | ||
| import pytest | ||
|
|
||
| from src.create_input import conv_filename_to_condition, validate_inputs | ||
|
|
||
|
|
||
| def test_conv_filename_to_condition_match(): | ||
| pattern = r"(?P<noise>[^_]+)_(?P<level>\d+)\.wav" | ||
| result = conv_filename_to_condition("white_10.wav", pattern) | ||
| assert list(result.items()) == [("level", "10"), ("noise", "white")] | ||
|
|
||
|
|
||
| def test_conv_filename_to_condition_no_match(): | ||
| pattern = r"(?P<noise>[^_]+)_(?P<level>\d+)\.wav" | ||
| result = conv_filename_to_condition("unexpected.wav", pattern) | ||
| assert result == {"Unknown": "NoCondition"} | ||
|
|
||
|
|
||
| def test_validate_inputs_acr_minimal(): | ||
| cfg = {"number_of_gold_clips_per_session": "0"} | ||
| df = pd.DataFrame(columns=[ | ||
| "rating_clips", "math", "pair_a", "pair_b", "trapping_clips", "trapping_ans" | ||
| ]) | ||
| validate_inputs(cfg, df, "acr") | ||
|
|
||
|
|
||
| def test_validate_inputs_missing_column(): | ||
| cfg = {"number_of_gold_clips_per_session": "0"} | ||
| df = pd.DataFrame(columns=[ | ||
| "rating_clips", "math", "pair_a", "trapping_clips", "trapping_ans" | ||
| ]) | ||
| with pytest.raises(AssertionError): | ||
| validate_inputs(cfg, df, "acr") |
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. too basic. What is the aim of this test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| from src.result_parser import outliers_modified_z_score, outliers_z_score | ||
|
|
||
|
|
||
| def test_outliers_modified_z_score_removes_outlier(): | ||
| data = [1, 1, 1, 100] | ||
| assert outliers_modified_z_score(data) == [1, 1, 1] | ||
|
|
||
|
|
||
| def test_outliers_z_score_threshold_high(): | ||
| data = [10, 10, 10, 1000] | ||
| # With default threshold 3.29 the outlier is not removed | ||
| assert outliers_z_score(data) == data |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too basic. create_input is not user faced. Maybe tests for the master_script.py should be the target here.