[Workspaces] Migrate Editor from WPF to WinUI 3#49077
Open
chatasweetie wants to merge 69 commits into
Open
Conversation
…PO/singleton checks, window state persistence, hotkey toggle, IconHelper.
…data templates with Expanders, search/sort, app position editing, save/cancel navigation
…pture flow: minimize → capture dialog → snapshot tool → edit page.
…I, update module interface to launch from WinUI3Apps subfolder, eelete old WPF WorkspacesEditor project
…pshot in OnClosed if already captured
…s shown during capture, due to WinUI limiation for multi-window support
…, sort/position ComboBoxes, CLI TextBox, position fields, editor heading, and snapshot description for screen reader support
…indow size persistence across DPI-scaled monitors
… there is a flyout
…ot work for winui
|
Thank you for contributing to PowerToys. We've detected that this PR might include a new or modified telemetry event. Please ensure the following before merging:
|
…m/microsoft/PowerToys into workspaces-editor-winui-migration # Conflicts: # src/modules/Workspaces/WorkspacesEditor.WinUI/Views/MainPage.xaml # src/modules/Workspaces/WorkspacesEditor.WinUI/Views/MainWindow.xaml # src/modules/Workspaces/WorkspacesEditor.WinUI/Views/SnapshotWindow.xaml # src/modules/Workspaces/WorkspacesEditor.WinUI/Views/WorkspacesEditorPage.xaml # src/modules/Workspaces/WorkspacesEditor.WinUI/WorkspacesEditor.WinUI.csproj
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Migrates the Workspaces Editor from WPF (System.Windows) to WinUI 3 (Microsoft.UI.Xaml / Windows App SDK), completing the Workspaces module WinUI modernization.
PR Checklist
Detailed Description of the Pull Request / Additional comments
DISABLE_XAML_GENERATED_MAIN, GPO check, singleton mutexDispatcherQueue/DispatcherTimerfor UI thread operationsAppWindowfor window sizing, positioning, min-size enforcementObservableObject,[ObservableProperty],[RelayCommand]StrongReferenceMessengerfor View↔ViewModel decoupling (8 message types){x:Bind}on MainPage,{Binding}on WorkspacesEditorPage (see lessons learned below)OverlayBorder.cs— 4 opaque WinUI windows per monitor with DWM chrome removal)AutomationProperties.Name,HeadingLevel,LiveSetting,ListViewfor list semantics, contextual button labelsMVVM Architecture
NavigateToEditorMessage,GoBackMessageShowSnapshotWindowMessage,MinimizeWindowMessage,RestoreWindowMessageCloseApplicationMessageSnapshotWindowfully decoupled — communicates viaSnapshotCapturedMessage/SnapshotCancelledMessageValidation Steps Performed
workspace-editor-winui-migration.mp4