CmdPal: Fix "Open Command Palette" dock item#49095
Conversation
DockControl only opens Command Palette for page commands. The recent dock home change introduced GoHomeDockCommand as an invokable command, so the Palette no longer opened from the dock item. - Restore dock home to use the shared root page. - Add a deferred root page accessor to avoid DI cycles.
|
I don't think I'm understanding why this complexity is needed. When I click the cmdpal "button" on the dock, cmdpal opens and goes home. What am I missing? |
PowerToys/src/modules/cmdpal/Microsoft.CmdPal.UI/Dock/DockControl.xaml.cs Lines 448 to 453 in de48594 PowerToys/src/modules/cmdpal/Microsoft.CmdPal.UI/Dock/DockControl.xaml.cs Lines 437 to 440 in de48594 We can either add an exception for this, add a new message, or revert to using the main list page as a command. IIRC, that was the original solution. cd7465e removed dependency on the root page to avoid circular dependency (see commit description):
|
michaeljolley
left a comment
There was a problem hiding this comment.
One nit, otherwise 👍🏼
Summary of the Pull Request
This PR fixes the "Open Command Palette" dock item.
Dock only opens Command Palette for page commands (see DockControl.InvokeItem). The recent dock home change introduced
GoHomeDockCommandas an invokable command, so the Palette no longer opened from the dock item.PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed