Add PR Needs-Author-Feedback lifecycle to fabricbot configuration#49151
Open
MuyuanMS wants to merge 1 commit into
Open
Add PR Needs-Author-Feedback lifecycle to fabricbot configuration#49151MuyuanMS wants to merge 1 commit into
MuyuanMS wants to merge 1 commit into
Conversation
Adds fabricbot rules to handle Needs-Author-Feedback on PRs: - After 7 days of no activity: add Status-No recent activity + warning - After 7 more days (14 total): close PR with explanation comment - When author pushes commits: remove Needs-Author-Feedback, add Needs-Triage - When PR has any activity: remove Status-No recent activity This is a simpler alternative to the GitHub Actions workflow approach, trading the draft-conversion feature for zero-maintenance fabricbot automation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the existing FabricBot (GitOps.PullRequestIssueManagement) policy to manage the Needs-Author-Feedback label lifecycle for pull requests, mirroring the existing stale/close automation already in place for issues.
Changes:
- Add scheduled searches for PRs to warn after 7 days of inactivity and close after an additional 7 days (using
Status-No recent activity). - Add an event responder for PR
Synchronize(new commits) by the PR author to removeNeeds-Author-Feedbackand re-queue withNeeds-Triage. - Add an event responder to remove
Status-No recent activityon any PR update activity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds fabricbot rules to manage the
Needs-Author-Feedbacklabel lifecycle for pull requests, complementing the existing issue management rules inresourceManagement.yml.This is a simpler alternative to the GitHub Actions workflow approach (PR #48812), trading advanced features (draft conversion, author-specific activity tracking) for zero-maintenance fabricbot automation.
Behavior
Flow diagram
Scheduled searches (every 6 hours)
Needs-Author-Feedback+ 7 days inactive + noStatus-No recent activityStatus-No recent activitylabel + warning commentNeeds-Author-Feedback+Status-No recent activity+ 7 more days inactiveEvent responders
Issue_Comment+issueAuthor)Needs-Author-Feedback, addNeeds-Triage+Needs-Team-ResponsePull_Request+Synchronize+issueAuthor)Needs-Author-Feedback, addNeeds-TriageStatus-No recent activityBot messages
Warning (at 7 days):
Closing (at 14 days):
Comparison with GitHub Actions workflow (PR #48812)
workflow_dispatch+ dry-runTrade-offs
Pros:
Cons:
noActivitySincecounts all activity — bot comments, maintainer comments, and label changes all reset the inactivity timerRelationship to existing automation
Mirrors the existing issue rules (lines 11-43) which use the same pattern: