CmdPal: Fix stale fallback scores by re-scoring global fallbacks at read time#49211
Open
jiripolasek wants to merge 1 commit into
Open
CmdPal: Fix stale fallback scores by re-scoring global fallbacks at read time#49211jiripolasek wants to merge 1 commit into
jiripolasek wants to merge 1 commit into
Conversation
- Replaces eager scoring of global fallback items with re-scoring on every GetItems call, so asynchronously updated titles get fresh scores and items with momentarily empty titles are no longer dropped for the rest of the query - Captures the fuzzy query together with the matcher that precomputed it, so read-time scoring always uses a schema-consistent query/target pair even if settings hot-swap the matcher - Reuses the already prefiltered global fallback list instead of recomputing it with a second LINQ pass - Trims the result array in MainListPageResultFactory when a concurrently cleared title reduces the written item count, so callers never see null slots - Removes the dead GetNonEmptyFallbackItemsCount helper and corrects the misleading deferred-execution comments on the fallback fields - Adds a factory test covering a fallback title cleared between visibility filtering and the merge
github-actions
Bot
added
the
Product-Command Palette
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR fixes issue with search scores of fallback items being stale and calculated from the old value.
_fallbackItemsfromIEnumerableto an array to emphasize that it is not lazily evaluated. There is no change in semantics; the list was already materialized. This only changes the type to make that explicit to developers.PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed