Skip to content

Fix case sensitivity issue in R4 functional test file names#248

Draft
Copilot wants to merge 2 commits intomasterfrom
copilot/fix-243
Draft

Fix case sensitivity issue in R4 functional test file names#248
Copilot wants to merge 2 commits intomasterfrom
copilot/fix-243

Conversation

Copy link
Copy Markdown

Copilot AI commented Jul 17, 2025

This PR fixes a case sensitivity issue in the R4 functional tests that was causing test failures when run manually.

Problem

The issue reported that "shared functional tests are not run" and mentioned a failing test that was only visible when run manually. After investigation, the root cause was identified as a case sensitivity mismatch in test file names:

  • Test code expected: "R4OnlyResource/Organizationaffiliation.json" (lowercase 'a')
  • Actual file name: "R4OnlyResource/OrganizationAffiliation.json" (capital 'A')

This caused the following test to fail:

GivenAR4OnlyResource_WhenAnonymizing_AnonymizedJsonShouldBeReturned(testFile: "R4OnlyResource/Organizationaffiliation.json", targetFile: "R4OnlyResource/Organizationaffiliation-target.json")

With error:

Could not find file 'TestResources/R4OnlyResource/Organizationaffiliation.json'

Solution

Updated the test data in VersionSpecificTests.cs to use the correct case-sensitive file names:

  • Organizationaffiliation.jsonOrganizationAffiliation.json
  • Organizationaffiliation-target.jsonOrganizationAffiliation-target.json

Investigation Results

During investigation, I confirmed that:

  1. Shared functional tests (.shproj files) are properly imported into R4 and Stu3 test projects via <Import Project="..." /> statements
  2. The current testProjects: "**/*Tests/*.csproj" pattern in release.yml correctly captures all runnable test projects
  3. Shared functional tests ARE being executed as part of the CI pipeline through the importing concrete projects
  4. No changes to release.yml are needed

Test Results

  • Before: R4 Functional Tests: 36/37 tests passed ❌
  • After: R4 Functional Tests: 37/37 tests passed ✅
  • Stu3 Functional Tests: 37/37 tests passed ✅ (unchanged)

Fixes #243.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: chrisribe <1999791+chrisribe@users.noreply.github.com>
Copilot AI changed the title [WIP] Shared functional tests are not run Fix case sensitivity issue in R4 functional test file names Jul 17, 2025
Copilot AI requested a review from chrisribe July 17, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shared functional tests are not run

2 participants