Conversation
|
@jovinson-ms 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: jovinson-ms <88204686+jovinson-ms@users.noreply.github.com>
Co-authored-by: jovinson-ms <88204686+jovinson-ms@users.noreply.github.com>
|
@copilot can you change all references to "seed" to "key" to match the terminology in the existing code? And also move the documentation from a separate file to be a section in the main dicom documentation md file. |
…entation to main docs Co-authored-by: jovinson-ms <88204686+jovinson-ms@users.noreply.github.com>
I've updated all references from "seed" to "key" to match the existing codebase terminology and moved the documentation from the separate file to the main DICOM documentation file as requested. Changes include: Terminology Updates:
Documentation Consolidation:
All tests pass and the code now uses consistent terminology with the rest of the codebase. Commit: 3a5c1d7 |
This PR implements the ability to specify key values as optional parameters when de-identifying a specific data set in
AnonymizerEngine.AnonymizeDataset, allowing runtime override of configuration-based keys.Changes Made
New RuntimeKeySettings Class: Added a new class to hold optional runtime key values for
cryptoHashKey,dateShiftKey, andencryptKeythat can override configuration defaults.Enhanced AnonymizerEngine: Added a new overload
AnonymizeDataset(DicomDataset dataset, RuntimeKeySettings runtimeKeySettings)while maintaining full backward compatibility with the existingAnonymizeDataset(DicomDataset dataset)method.Updated Processors: Modified
CryptoHashProcessor,DateShiftProcessor, andEncryptProcessorto use runtime keys when available, falling back to configuration keys when not provided.ProcessContext Enhancement: Extended
ProcessContextto pass runtime keys to processors through the anonymization pipeline.Usage Example
Benefits
Testing
Added comprehensive unit tests covering:
All existing tests continue to pass, demonstrating no regressions were introduced.
Fixes #249.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.