Fix schema config being dropped in ActionSchemaFileCache.getSchemaSource#2016
Merged
curtisman merged 1 commit intomicrosoft:mainfrom Mar 18, 2026
Merged
Fix schema config being dropped in ActionSchemaFileCache.getSchemaSource#2016curtisman merged 1 commit intomicrosoft:mainfrom
curtisman merged 1 commit intomicrosoft:mainfrom
Conversation
getSchemaSource was returning config: undefined instead of config: schemaContent.config, causing schema config to be dropped for TypeScript schemas. This meant config changes would not invalidate the cache hash, and downstream schema parsing would not receive the config. Added tests to verify config is preserved and affects hash.
curtisman
requested a deployment
to
development-fork
GitHub Actions
Waiting
curtisman
requested a deployment
to
development-fork
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getSchemaSourcewas returningconfig: undefinedinstead ofconfig: schemaContent.config, causing schema config to be dropped for TypeScript schemas. This meant:Changes
schemaContent.configinstead of hardcodedundefined