shell: replace closedSet+openWildcard with noMatchPolicy#2022
Open
curtisman wants to merge 1 commit intomicrosoft:mainfrom
Open
shell: replace closedSet+openWildcard with noMatchPolicy#2022curtisman wants to merge 1 commit intomicrosoft:mainfrom
curtisman wants to merge 1 commit intomicrosoft:mainfrom
Conversation
curtisman
had a problem deploying
to
development-fork
GitHub Actions
Error
curtisman
had a problem deploying
to
development-fork
GitHub Actions
Error
Refactor PartialCompletionSession to compute a single NoMatchPolicy
enum ("accept" | "refetch" | "slide") from the backend's descriptive
closedSet and openWildcard fields when a result arrives.
The shell's reuseSession() decision points (A3 and C6) now use a
simple switch on the policy instead of checking two booleans
independently. No changes to the wire format, agent SDK, dispatcher,
or grammar matcher -- all stay descriptive.
Update docs/architecture/completion.md to document NoMatchPolicy
derivation and rationale.
curtisman
force-pushed
the
curtism/shell-noMatchPolicy
branch
from
d74c4a0 to
1565e0d
Compare
curtisman
requested a deployment
to
development-fork
GitHub Actions
Waiting
curtisman
requested a deployment
to
development-fork
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
PartialCompletionSessionto compute a singleNoMatchPolicyenum ("accept"|"refetch"|"slide") from the backend's descriptiveclosedSetandopenWildcardfields when a result arrives.The shell's
reuseSession()decision points (A3 and C6) now use a simpleswitchon the policy instead of checking two booleans independently. No changes to the wire format, agent SDK, dispatcher, or grammar matcher — all stay descriptive.Changes
partialCompletionSession.ts: ReplaceclosedSet+openWildcardprivate fields with a singlenoMatchPolicy: NoMatchPolicyfield. AddcomputeNoMatchPolicy()pure function. Simplify A3 and C6 branches toswitchstatements.completion.md: DocumentNoMatchPolicyderivation, rationale, and per-trigger behavior. UpdateclosedSet/openWildcardkey-type sections to note they're folded into the policy in the shell.Testing
All 104 existing shell completion tests pass (7 test suites).