Thread typesMapLocation down to the ProjectService#22776
Merged
amcasey merged 1 commit intomicrosoft:masterfrom Sep 19, 2018
Merged
Thread typesMapLocation down to the ProjectService#22776amcasey merged 1 commit intomicrosoft:masterfrom
amcasey merged 1 commit intomicrosoft:masterfrom
Conversation
Member
Author
|
In the course of trying to write a test for this, I discovered that neither VS nor VS Code uses it. Feel free to re-open if we find a use case. Otherwise, it seems like a better fix would be to delete the switch. |
Member
Member
Author
|
@sheetalkamat I don't remember any of the specifics of this change, so I just rebased on master. |
sheetalkamat
approved these changes
Sep 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22607