fix unnecessary Reference Check with property signature#23964
Closed
Kingwl wants to merge 2 commits intomicrosoft:masterfrom
Closed
fix unnecessary Reference Check with property signature#23964Kingwl wants to merge 2 commits intomicrosoft:masterfrom
Kingwl wants to merge 2 commits intomicrosoft:masterfrom
Conversation
mhegazy
reviewed
May 9, 2018
| return true; | ||
| } | ||
|
|
||
| if (isComputedPropertyName(current) && isPropertySignature(current.parent) && current.parent.name === current) { |
Contributor
There was a problem hiding this comment.
that will also allow it inside the class body, which is not correct.
Contributor
There was a problem hiding this comment.
class C{
[C.a] = 0;
static a = "a";
}That would be throw based on the current TC39 proposal for class properties
Contributor
Author
|
@mhegazy could you give some example please? |
Kingwl
force-pushed
the
unnecessary-property-signature
branch
from
2a239d0 to
c984361
Compare
Member
|
Toggling to queue a fresh CI build |
Member
|
Red CI and unaddressed comments for several months. Feel free to open a fresh PR as usual @Kingwl 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23829