check more case for empty binding patten#25263
Merged
RyanCavanaugh merged 7 commits intoApr 26, 2019
Merged
Conversation
RyanCavanaugh
requested changes
Sep 5, 2018
Member
RyanCavanaugh
left a comment
RyanCavanaugh
left a comment
There was a problem hiding this comment.
Please fix spelling and merge conflicts. Thanks!
| if (strictNullChecks && node.name.elements.length === 0) { | ||
| checkNonNullType(initializerType, node); | ||
| const needCheckInitializer = node.initializer && node.parent.parent.kind !== SyntaxKind.ForInStatement; | ||
| const needCheckWinendType = node.name.elements.length === 0; |
Member
|
@Kingwl ping on this one - would be ready to merge after fixes |
Contributor
Author
|
🙋🏻♂️ |
Member
|
@Kingwl I promise to merge after the conflict is resolved! 👋 |
Contributor
Author
|
@typescript-bot test this. |
Collaborator
Kingwl
force-pushed
the
Destructuring_assignment_assignability_check
branch
from
2acf313 to
d88c01e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24634