24542 - bad error message for import *-ing an export=

[a-tarasyuk]

Fixes #24542

[mhegazy]

@DanielRosenwasser can you please review this change.

[DanielRosenwasser]

@mhegazy @weswigham what about

When writing ECMAScript imports, callable/constructable 'export ='-style modules can only be imported by turning on the 'esModuleInterop' flag and using a default import.

[weswigham]

@DanielRosenwasser we can equally point people to import a = require when not targeting esnext and is usually a less error-prone change than turning on esModuleInterop; which is why the original message was "cannot be imported using this construct".

[a-tarasyuk]

@DanielRosenwasser @weswigham Should I change the message to

When writing ECMAScript imports, callable/constructable 'export ='-style modules can only be imported by turning on the 'esModuleInterop' flag and using a default import.

?

Maybe the message should rely on module type(es2015, cjs), what do you think?

[DanielRosenwasser]

Hey @a-tarasyuk - I think you're right, but in those circumstances we need to just recommend people use allowSyntheticDefaultImports, not esModuleInterop. Does that sound right @weswigham?

[a-tarasyuk]

@DanielRosenwasser thanks for your answer, will wait for the answer from @weswigham in order to understand which message should I use for this case as the message from Expected section - #24542 is not right.

[weswigham]

Hey @a-tarasyuk - I think you're right, but in those circumstances we need to just recommend people use allowSyntheticDefaultImports, not esModuleInterop

If module < es2015, esModuleInterop, otherwise alliwSyntheticDefaultImports.

[mhegazy]

@DanielRosenwasser can you take a look.

[mhegazy]

@DanielRosenwasser mentioned he had some comments offline. @DanielRosenwasser can u please comment

[DanielRosenwasser]

Thank you for the PR and your patience!