visit exclamation token#26151
Merged
rbuckton merged 5 commits intomicrosoft:masterfrom Apr 24, 2019
Merged
Conversation
| nodesVisitor((<PropertyDeclaration>node).modifiers, visitor, isModifier), | ||
| visitNode((<PropertyDeclaration>node).name, visitor, isPropertyName), | ||
| visitNode((<PropertyDeclaration>node).questionToken, tokenVisitor, isToken), | ||
| visitNode((<PropertyDeclaration>node).questionToken, tokenVisitor, isToken) || visitNode((<PropertyDeclaration>node).exclamationToken, tokenVisitor, isToken), |
Contributor
There was a problem hiding this comment.
Actually, || would have been better in this case because the argument only allows one or the other. I've suggested a more concise approach in another comment.
Kingwl
force-pushed
the
PropertyDeclarationExclamationToken
branch
from
eb20823 to
723ee8a
Compare
RyanCavanaugh
requested changes
Sep 5, 2018
rbuckton
suggested changes
Feb 6, 2019
Member
|
@Kingwl - ping - can you address or close? Thanks |
Co-Authored-By: Kingwl <kingwenlu@gmail.com>
rbuckton
approved these changes
Apr 24, 2019
Contributor
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25789