Skip to content

Change esnext.asynciterable to es2018.asynciterable#26220

Merged
rbuckton merged 7 commits into
microsoft:masterfrom
saschanaz:async-es2018
Feb 7, 2019
Merged

Change esnext.asynciterable to es2018.asynciterable#26220
rbuckton merged 7 commits into
microsoft:masterfrom
saschanaz:async-es2018

Conversation

@saschanaz
Copy link
Copy Markdown
Contributor

Fixes #26218

@RyanCavanaugh
Copy link
Copy Markdown
Member

Please resolve merge conflict. Thanks!

@saschanaz
Copy link
Copy Markdown
Contributor Author

@RyanCavanaugh Done and the test passes!

@johndoe23612896381634
Copy link
Copy Markdown

When will this PR be merged?

@johndoe2361289638165
Copy link
Copy Markdown

C'mon Microsoft, pls merge and release it!

@jordanbtucker
Copy link
Copy Markdown

jordanbtucker commented Jan 19, 2019

Async iterators were moved to Stage 4 almost a year ago. Does it normally take this long to update lib typings and targets?

@johndoe2361289638165
Copy link
Copy Markdown

Still not merged...? C'mon...

["es2018.regexp", "lib.es2018.regexp.d.ts"],
["esnext.array", "lib.esnext.array.d.ts"],
["esnext.symbol", "lib.esnext.symbol.d.ts"],
["esnext.asynciterable", "lib.esnext.asynciterable.d.ts"],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For backwards-compatibility sake we might want to have lib.esnext.asynciterable.d.ts that just has a /// <reference lib="es2018.asynciterable" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, a simpler approach would be to have ["esnext.asynciterable", "lib.es2018.asynciterable.d.ts"], here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@johndoe2361289638165
Copy link
Copy Markdown

..........

@rbuckton
Copy link
Copy Markdown
Contributor

rbuckton commented Feb 7, 2019

This looks good although the PR seems to have caught up some recent changes in master that seem to be unrelated, so I may have to merge manually.

@rbuckton rbuckton merged commit 5a6dc08 into microsoft:master Feb 7, 2019
@rbuckton
Copy link
Copy Markdown
Contributor

rbuckton commented Feb 7, 2019

Thanks for the contribution!

@saschanaz saschanaz deleted the async-es2018 branch February 7, 2019 21:56
@saschanaz saschanaz mentioned this pull request Nov 24, 2020
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants