Skip to content

error on set accessor without get accessor#26338

Closed
ajafff wants to merge 1 commit intomicrosoft:masterfrom
ajafff:lonely-setter
Closed

error on set accessor without get accessor#26338
ajafff wants to merge 1 commit intomicrosoft:masterfrom
ajafff:lonely-setter

Conversation

@ajafff
Copy link
Copy Markdown
Contributor

@ajafff ajafff commented Aug 9, 2018

Fixes: #11596

@ajafff
Copy link
Copy Markdown
Contributor Author

ajafff commented Aug 9, 2018

@typescript-bot test this

Edit: this seems to be restricted to members only?

@weswigham
Copy link
Copy Markdown
Member

weswigham commented Aug 20, 2018

@ajafff Indeed - it is limited to repo owners and MS org members right now (it holds up a lot (1 of our 5 containers for around half an hour) of resources to run them and we don't want them triggered frivolously). @RyanCavanaugh I imagine you want to monitor the result, since you suggested it.

@typescript-bot test this

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Aug 20, 2018

Heya @weswigham, I've started to run the extended test suite on this PR at 0482b61. You can monitor the build here. It should now contribute to this PR's status checks.

@weswigham
Copy link
Copy Markdown
Member

So this introduces errors into 10 of our RWC projects, with little added value - the setter-only objects mostly look like they're clearly written to actually be setter only - mostly membranes that do a little extra work on write. TBH, I personally have no problem with most of the usages in our RWC suite - they make a good argument for properly recognizing writeonly props.

@RyanCavanaugh
Copy link
Copy Markdown
Member

Sounds like this needs to block on #21759 then?

@weswigham
Copy link
Copy Markdown
Member

weswigham commented Aug 23, 2018

I'd say so, yeah. I don't think we can make it an error reasonably when people can't yet express the state in which a setter-only property is correct (and I think we'd still need a flag to opt-out of the new error - some projects like vscode seem to use setter-only stuff heavily and all those types probably won't get updated to writeonly at once).

@RyanCavanaugh RyanCavanaugh added this to the Community milestone Sep 17, 2018
@RyanCavanaugh
Copy link
Copy Markdown
Member

Closing because this can't be merged unless #21759 happens (which is quite unlikely in the near future)

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants