fix lookup regression again and again#26810
Conversation
|
@Kingwl thank you for your persistence and timely responses on this! Obviously we are starting to get a little worried - #26813 also just came up, though it appears to be fixed by this PR. I'm going to revert the prior two PRs and ask that you submit a fresh PR with this fix and the prior ones all rolled into one, along with testcases. I'll put the tests in the revert PR, along with an extracted repro from #26813, so that we can more easily review the changes together and make sure the right thing is happening. Thanks again! |
|
#26820 is in now, so please rebase |
|
sorry about that😅 |
|
updated |
|
@ahejlsberg this is the cleaned-up PR we discussed last week |
|
@Kingwl can you fix the merge conflict? Sorry for the delay |
|
sure, a few moments later |
Kingwl
force-pushed
the
fix_lookup_regression_again_and_again
branch
from
7763347 to
20054d9
Compare
|
Looks good; let's see what shows up in nightly feedback 😅 |
|
seems everything is ok 😆 |
3 participants
Fixes #26808
hope do not fix again and again and again🤷🏻♂️