fix: do not parse mpeg-ts files as typescript files#26958
Closed
KnisterPeter wants to merge 2 commits intomicrosoft:masterfrom
Closed
fix: do not parse mpeg-ts files as typescript files#26958KnisterPeter wants to merge 2 commits intomicrosoft:masterfrom
KnisterPeter wants to merge 2 commits intomicrosoft:masterfrom
Conversation
MPEG-TS files consist of frames each 188 bytes long. These files should not be parsed as typescript files and therefore we look into the first 50 frames and check if we find a 'valid' header. Closes microsoft#21136
Contributor
Author
|
@mhegazy @RyanCavanaugh The tests are still missing here, but if you don't mind I would love to get some feedback if the direction of this fix is correct. |
Member
|
Apologies for the delay here. I think we need to optimize this for incurring the absolute minimum overhead in the common case where none of the files are MPEGs. Specifically, that means the order of operations should be:
|
Member
|
Closing due to inactivity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MPEG-TS files consist of frames each 188 bytes long.
These files should not be parsed as typescript files
and therefore we look into the first 50 frames and
check if we find a 'valid' header.
Here's a checklist you might find useful.
'Bug' or 'help wanted' or is in the Community milestone
masterbranchjake runtestslocallyFixes #21136