Don't reformat body of arrow function when deleting its parameter#27168
Closed
Don't reformat body of arrow function when deleting its parameter#27168
Conversation
ghost
force-pushed
the
deleteArrowFunctionParameter
branch
from
d0f7d20 to
74c4b9f
Compare
ghost
force-pushed
the
deleteArrowFunctionParameter
branch
from
74c4b9f to
8974601
Compare
ghost
assigned
Author
|
Already done in #28217. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically a port of #23973
We no longer crash on the original repro, but still a good idea to not avoid reformatting any nodes we don't need to.