🤖 User test baselines have changed#27184
Closed
typescript-bot wants to merge 1 commit intomicrosoft:masterfrom
Closed
🤖 User test baselines have changed#27184typescript-bot wants to merge 1 commit intomicrosoft:masterfrom
typescript-bot wants to merge 1 commit intomicrosoft:masterfrom
Conversation
typescript-bot
force-pushed
the
user-update-20180802
branch
from
e5f11eb to
48c2d0a
Compare
weswigham
reviewed
Sep 18, 2018
Member
weswigham
left a comment
weswigham
left a comment
There was a problem hiding this comment.
It's all use before defined errors and one new error span from diving into return expressions. But wow is that a lot of used before definition errors.
Member
|
@weswigham bear in mind those will only show up with strict on. (strictNullChecks specifically). |
sandersn
requested changes
Sep 18, 2018
| @@ -1,6 +1,9 @@ | |||
| Exit Code: 1 | |||
| Standard output: | |||
| node_modules/acorn/bin/_acorn.js(46,22): error TS2565: Property 'parse' is used before being assigned. | |||
Member
There was a problem hiding this comment.
These are imported from an AMD-compiled dist folder.
| node_modules/adonis-framework/providers/ViewProvider.js(9,33): error TS2307: Cannot find module 'adonis-fold'. | ||
| node_modules/adonis-framework/src/Config/index.js(37,15): error TS2304: Cannot find name 'Mixed'. | ||
| node_modules/adonis-framework/src/Config/index.js(39,15): error TS2304: Cannot find name 'Mixed'. | ||
| node_modules/adonis-framework/src/Config/index.js(48,25): error TS2565: Property 'existy' is used before being assigned. |
Member
There was a problem hiding this comment.
This is incorrect; we shouldn't see a use-before-def error when imported from a module. Probably happens because these aren't real aliases?
Filed #27197
Member
|
Let's close this and wait for #27199 to get rid of the spurious use-before-def errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @RyanCavanaugh