Detect the input file of referenced project with fileNames from parsed command line#27195
Merged
sheetalkamat merged 2 commits intomasterfrom Sep 18, 2018
Merged
Detect the input file of referenced project with fileNames from parsed command line#27195sheetalkamat merged 2 commits intomasterfrom
sheetalkamat merged 2 commits intomasterfrom
Conversation
ajafff
reviewed
Sep 18, 2018
Contributor
There was a problem hiding this comment.
Does this work for transitive projectReferenes? I'm asking because I struggled with that too.
// @filename: tsconfig.a.json
{"compilerOptions": {"composite"}, "files": ["a.ts"]}
// @filename: a.ts
export class A {}
// @filename: tsconfig.b.json
{"compilerOptions": {"composite"}, "files": ["b.ts"], "references": [{"path": "tsconfig.a.json"}]}
// @filename: b.ts
import {A} from './a';
export const b = new A();
// @filename: tsconfig.c.json
{"files": ["c.ts"], "references": [{"path": "tsconfig.b.json"}]}
// @filename: c.ts
import {b} from './b';
console.log(b);Compiling tsconfig.c.json should resolve imports as b.d.ts and a.d.ts. I guess the current implementation resolves imports to b.d.ts and a.ts.
RyanCavanaugh
approved these changes
Sep 18, 2018
Member
Author
|
Created #27200 for the transitive issue which wont be part of this PR. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25864 and #26054