Skip to content

Fix signature help not showing in block body bug#27203

Merged
DanielRosenwasser merged 1 commit intomicrosoft:masterfrom
sbaidon:signatureHelpInAdjacentBlockBody
Oct 8, 2018
Merged

Fix signature help not showing in block body bug#27203
DanielRosenwasser merged 1 commit intomicrosoft:masterfrom
sbaidon:signatureHelpInAdjacentBlockBody

Conversation

@sbaidon
Copy link
Copy Markdown
Contributor

@sbaidon sbaidon commented Sep 18, 2018

This change fixes manual triggering inside adjacent block body.

Basically if it was a manual invocation it keeps walking up.

Fixes issue #27056

@msftclas
Copy link
Copy Markdown

msftclas commented Sep 18, 2018

CLA assistant check
All CLA requirements met.

@RyanCavanaugh RyanCavanaugh added this to the TypeScript 3.2 milestone Sep 20, 2018
@DanielRosenwasser DanielRosenwasser merged commit 8474949 into microsoft:master Oct 8, 2018
@DanielRosenwasser
Copy link
Copy Markdown
Member

Thanks for the patience and the PR!

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants